merge vmimage pkg #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anrs
reviewed
Jul 3, 2024
| return imgName | ||
| } | ||
|
|
||
| func GetMockManager() *mocks.Manager { |
There was a problem hiding this comment.
how about putting a test file, or initializing from calling point
There was a problem hiding this comment.
I can't find a good place to put these code, because if initializing at calling point, then we need provoide a function to set the global instance of factory pkg with the mocked object, I think it's ugly
anrs
reviewed
Jul 3, 2024
pkg/vmimage/utils/image.go
Outdated
| err = fmt.Errorf("invalid image name: %s", fullname) | ||
| return | ||
| } | ||
| if user == "" { |
There was a problem hiding this comment.
this if block seems can be removed?
anrs
reviewed
Jul 3, 2024
pkg/vmimage/utils/image.go
Outdated
| user = "" | ||
| } | ||
| parts = strings.Split(nameTag, ":") | ||
| switch len(parts) { |
There was a problem hiding this comment.
can be simplified as switch parts = strings.Split(nameTag, ":"); len(parts) {
|
rest of them LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge github.com/yuyang0/vmimage